Skip to content

🪲 BUG-#32: Custom model silently reverted to defaultModel on every provider - #33

Merged
FernandoCelmer merged 1 commit into
masterfrom
feature/32
Aug 16, 2026
Merged

🪲 BUG-#32: Custom model silently reverted to defaultModel on every provider#33
FernandoCelmer merged 1 commit into
masterfrom
feature/32

Conversation

@FernandoCelmer

Copy link
Copy Markdown
Member

Description

  • src/features/settings/settings.controller.ts — storedModelFor() and healStaleModel() no longer treat "not in def.models" as stale. def.models is a curated shortlist for the QuickPick menu, not an exhaustive whitelist — local providers (Ollama, LM Studio) in particular have open-ended model names. healStaleModel() now only falls back to defaultModel when the active provider has no model set at all, instead of force-resetting any custom entry.

Motivation and Context

Setting a custom model via "Custom…" in the model picker didn't stick — postSettings() (called right after updateSetting("model", model) in both changeProviderModel() and connectProvider(), and again on nearly every settings-affecting action) ran healStaleModel(), which force-reverted the model back to defaultModel whenever it wasn't a member of the hardcoded models: string[] list. Reported against Ollama, but reproduces for every entry in PROVIDER_CATALOG.

Closes #32.

Types of changes

  • Bug fix (change that fixes an issue)
  • New feature
  • Documentation

Checklist

  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective
  • I have updated the CHANGELOG
  • I have updated the documentation accordingly

@FernandoCelmer FernandoCelmer added the bug Something isn't working label Aug 16, 2026

@FernandoCelmer FernandoCelmer left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two blocking issues found in the model validation logic.

Comment thread src/features/settings/settings.controller.ts
Comment thread src/features/settings/settings.controller.ts
@FernandoCelmer
FernandoCelmer merged commit ebcd7e1 into master Aug 16, 2026
2 checks passed
@FernandoCelmer
FernandoCelmer deleted the feature/32 branch August 16, 2026 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom model is silently reverted to defaultModel on every provider

1 participant